search

dextboy / pe

0 stars 0 forks source link

Lack of exception handling after inactivity #5

Open dextboy opened 2 months ago

dextboy commented 2 months ago

Steps to reproduce login into the app leave the app inactive for 3 minutes hit enter button on keyboard

Screenshot 2024-04-19 at 4.25.46 PM.png

App should handle exception errors when inactivity timer expires and user hits enter button on keyboard.

nus-se-script commented 2 months ago

Team's Response

Thanks for pointing this out, this should not have happened.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lack of exception handling when prompted to continue

Steps to reproduce login to the app wait past 30 seconds (ignore the "please prompt again..", I hit enter to prevent inactivity) type 'no' when prompted to continue

Screenshot 2024-04-19 at 4.28.10 PM.png

App should handle exception errors when 'no' is entered when prompted to continue.

[original: nus-cs2113-AY2324S2/pe-interim#1310] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out, you are right that there should be better exception handling here

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The situation that the exception is thrown differs, one is 30 seconds (while still using the app, while the app is still active), while the other is after 3 minutes (when logged out, when the app is not supposed to be active), leaving me to believe that these are two separate fixes. Additionally, the error in exception occurs at 2 different areas. (If you look at the stack trace you will notice it starts at line 90 and line 102). These are different lines leading to different errors. For these reasons, I disagree with the duplication.