search

dexter-psychometrics / dexterMML

An add on to dexter for situations where CML estimation is impossible.
GNU General Public License v3.0
3 stars 0 forks source link

Added macOS installation instructions #1

Closed jvdneut closed 2 years ago

jvdneut commented 2 years ago

I've added instructions for installing on macOS in a separate dexterMML setup on macOS.md file.

Additionally a missing #include was added to nrm_full_hessian.cpp that blocked the compiler on macOS. Strangely enough this did not cause problems on Windows.

jessekps commented 2 years ago

Thanks, possibly a different collation sequence on mac then but it is indeed a bug.

In your installation instruction for mac I saw this: devtools::install_github("jvdneut/dexterMML") Is that necessary? i.e. did you make further changes?

jvdneut commented 2 years ago

I should have mentioned that. The instruction points to my fork only because of internal use.

This should point to your original repository when merged, so devtools::install_github("dexter-psychometrics/dexterMML")

jessekps commented 2 years ago

Ah, you learn new something every day. Thanks for the work!

jvdneut commented 2 years ago

Thank you for merging! I have just successfully tested an install on macOS from your repository using devtools::install_github("dexter-psychometrics/dexterMML")

jvdneut commented 2 years ago

This should point to your original repository when merged, so devtools::install_github("dexter-psychometrics/dexterMML")

Ah, you learn new something every day. Thanks for the work!

To avoid confusion: this did not happen automatically, I meant that when merging this should have been done, but I force pushed this change to my fork seconds before you merged the pull request.