dexter-sim / pe

0 stars 0 forks source link

Bug when unable to read JSON file #4

Open dexter-sim opened 2 years ago

dexter-sim commented 2 years ago

When there is no read permission for the json file, there is no message told to the user.

This could result in the user adding a module, closing it, reopening it and the module disappears from the list.

Expected: Message in the result box that says file cannot be read.

Actual: error message thrown in the console WARNING: Error reading from jsonFile file data/modpro.json: java.nio.file.AccessDeniedException: data/modpro.json

nus-se-bot commented 2 years ago

Team's Response

image.png

Given that our application produces a json file with both write and read permissions enabled by default, the modifying of the read permission of the file and the handling of this type of file would be something our group considers as something less important to rectify given that it is highly unlikely and unusual that the user will modify the file to not have read permissions(that would require more advanced knowledge) and it qualifies for response.NotInScope by virtue of the second point where the app does not crash if you load a file with no read permissions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]