search

dexter-sim / pe

0 stars 0 forks source link

Inconsistent error message #8

Open dexter-sim opened 2 years ago

dexter-sim commented 2 years ago

Providing index 0 and 3 should result in the same error message. Expected behaviour is that both should give the 1st image.

image.png

image.png

soc-se-bot commented 2 years ago

Team's Response

The image for the bottom is to handle cases where the user keys in invalid numbers such as any non positive integer so the message to tell the user to key in an integer within the range specified is to guide to key in a positive integer. The top image is to address the issue where the user keys in a number not within the range of number of tasks in the task list. Given that these are two different scenarios, our team believes that they should be handled differently and not be merged as one common error.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From the user's point of view, there is no difference whether they put a negative number, 0, or 3. They are all considered invalid numbers and the error message should provide the range of values that are valid. In the case that the user writes 0 as the input, it should also give the same error message as when 3 is provided as the input. Both are invalid numbers and they are the same scenario to the user. The user does not care that the code handles the non positive integers case separately from indexOutOfBounds case. In both cases, the user should expect the error message to provide the range of values that are valid. Telling the user that the valid range is 0 to MAX_INT would not be correct in this case as the actual valid range is 0 to 3.