search

dexterpuru / leetcode_java

Archive for Leetcode solutions in Java
Creative Commons Zero v1.0 Universal
4 stars 15 forks source link

Group Anagrams #5

Closed MayankSingh173 closed 4 years ago

MayankSingh173 commented 4 years ago

https://github.com/dexterpuru/leetcode_java/issues/6

dexterpuru commented 4 years ago

@MayankSingh173 please make issue first, then after i assign the issue to you, then make the PR.

  1. Add question link to issue description
  2. After creating issue, edit this PR and put link of that issue in the PR description You should refer to currently opened issue to check the format, Please read the README to understand the procedure of contribution.
MayankSingh173 commented 4 years ago

@dexterpuru Heyy I'm new open source..Could you please help me how to make an issue.

dexterpuru commented 4 years ago

@MayankSingh173 sure,

  1. Go here:- https://github.com/dexterpuru/leetcode_java/issues/new
  2. Put question in title
  3. Put link to question in description
  4. If you want that issue to be assigned to yourself, write it at the end.
  5. After that i will assign that issue to you(if you wanted) and then you could open PR.
  6. PR title should have question as title and its description must have link of the Issue that you created in step 1.
dexterpuru commented 4 years ago

You don't need to close the PR, just make a issue, and after i assign that issue to you, edit the PR description and put the link of issue in it.

MayankSingh173 commented 4 years ago

Sorry...I closed the PR...I'll make a new PR

MayankSingh173 commented 4 years ago

I made an issue..can you please assign it me

MayankSingh173 commented 4 years ago

I add the necessary changes in the PR...Is it fine?

dexterpuru commented 4 years ago

Awesome work so far @MayankSingh173 I have only 3 requests:-

  1. Rename Question.txt to README.md
  2. Rename Solution.txt to Solution.java
  3. Move the Explanation of your approach from Question file to README.md.
YourAKShaw commented 4 years ago

@MayankSingh173 Kindly follow the instructions given by @dexterpuru Also, in the README.md for the problem statement, add problem link, problem statement and solution approach, in the the given order. You can check the other folders in the master branch of dexterpuru/leetcode_java for reference.

MayankSingh173 commented 4 years ago

Heyy @Ak-Shaw ....I kind of busy today...I'll make the necessary changes by tomorrow....Is it fine?.

YourAKShaw commented 4 years ago

Sure, take your time.

MayankSingh173 commented 4 years ago

Heyy @dexterpuru @Ak-Shaw ...I'm new to git and github...Can you please help me how should I add README.md file. I made that file in my pc.

MayankSingh173 commented 4 years ago

I made an another PR...Please let me know If am doing in a right way.