search

dexyfex / CodeWalker

https://www.gta5-mods.com/tools/codewalker-gtav-interactive-3d-map
473 stars 206 forks source link

fix ped components #251

Closed ook3D closed 2 months ago

ook3D commented 4 months ago

originally set as array of 5 bytes, when its actually an array of 5 floats.

dexyfex commented 3 months ago

Doesn't this just completely break the structure as it's changed length? since you changed 5 bytes instead to 5 floats (which is 20 bytes)... presumably those following unused fields are not actually unused and are just making up that 15 bytes difference?

You do test these PRs before you send them, right?

ook3D commented 3 months ago

Doesn't this just completely break the structure as it's changed length? since you changed 5 bytes instead to 5 floats (which is 20 bytes)... presumably those following unused fields are not actually unused and are just making up that 15 bytes difference?

You do test these PRs before you send them, right?

it works as its being used in this tool without issue, https://github.com/grzybeek/grzyClothTool

dexyfex commented 3 months ago

I just don't see how it could possibly work though

alexguirre commented 3 months ago

it works as its being used in this tool without issue, grzybeek/grzyClothTool

grzyClothTool actually removed those "unused" fields as they really were the floats of the array as dexy said. https://github.com/grzybeek/grzyClothTool/blob/79503b8976c3a13dcd5937f0631602422e361393/CodeWalker/CodeWalker.Core/GameFiles/MetaTypes/MetaTypes.cs#L6403-L6416

dexyfex commented 2 months ago

Manually applied this but with the extra fix (removed the unused fields)