deyaeddin / cert-manager-webhook-hetzner

cert-manager webhook for Hetzner DNS Public API (1.1.1)
https://dns.hetzner.com/api-docs
Apache License 2.0
7 stars 4 forks source link

Set App Version in release workflow #59

Closed yoo closed 1 year ago

yoo commented 3 years ago

Right now the image tag pulled by kubernetes defaults to latest, with the image pull policy IfNotPresent this leads to the image not being updated. This PR fixes this by dropping the image tag from the values file and updating the appVresion to the container image tag when packaging the helm chart.

I am not exactly sure what the next tag should be since the artifact hub shows an app version of 1.1.0. Either break with semver and just use 0.2.x or bump everything to 2.x. If you think the appVersion should be set some other way let me know.