deyanTG / caldav4j

Automatically exported from code.google.com/p/caldav4j
0 stars 0 forks source link

[PATCH] createTicked failed when ticked has no timeout #16

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create ticket with no timeout (null)

What is the expected output? What do you see instead?

createTicket will fail, because of server responds with "Infinite"

Please provide any additional information below.
patch will cure this problem. I do not created test because of awaiting
accepting my previous patch to CalDAVCalendarCollectionTest.java ;)

Original issue reported on code.google.com by vova...@gmail.com on 12 Sep 2008 at 2:45

Attachments:

GoogleCodeExporter commented 8 years ago
We should verify if it's ok: maybe if a bad timeout was sent, we could throw an
exception too...

thx for your help + Peace,
R

PS: patches CalDAVCalendarCollectionTest.java and CalDAVCollectionTest.java 
should as
possible add methods instead of replacing it. This because I'd like to preserve
Bobby's job and backward compatibility.

Original comment by robipo...@gmail.com on 12 Sep 2008 at 4:02

GoogleCodeExporter commented 8 years ago
my patch does not replaced methods, just used messages from bundle. So it gives 
you
possibility to test whole the library against non-latin characters, not only 
selected
methods 

Original comment by vova...@gmail.com on 12 Sep 2008 at 6:05

GoogleCodeExporter commented 8 years ago
another problem is how to specify infinite timeout. For visits you used -1, but 
for
timeout this value is null

Original comment by vova...@gmail.com on 12 Sep 2008 at 8:32