search

deyles-zz / sculejs

SculeJS - data structures for the web
165 stars 24 forks source link

Fix for Issue #29 #30

Closed sehrgut closed 11 years ago

sehrgut commented 11 years ago

Here's my fix for Issue #29. I'm working under Windows right now, so I couldn't create an expresso test case. I hope you'll forgive the nodeunit test case, but it demonstrates the issue and fix. Cheers!

sehrgut commented 11 years ago

Aw, crap, I just noticed that my editor fubarred the EOLs, so you may not want to merge this as-is. Still, it gives you the gist of it.

deyles-zz commented 11 years ago

Yup, all good. I'll probably include a variation of the ohas function in the general functions module rather than directly in the data structures module. There are also probably other SculeJS classes that have a similar vulnerability, so I'll eyeball the code to figure out where changes need to be applied.

Thanks again for contributing, it's great knowing there are folk out there using this code and making the effort to understand how it all fits together.

sehrgut commented 11 years ago

No prob . . . thanks for this library! The only competition it really has is collection, which requires a native binary (and also doesn't play nicely with w32).