Open ludolphus opened 11 years ago
This is an interesting case. I think I'll have to detect emojis, if they exist, and offset all characters after that character instance by 4.
Another interesting scenario I came across is that when tapping the link, in case of multi-word links, only the tapped word is highlighted, not the entire bit.
— Sent from Mailbox for iPad
On Mon, Oct 7, 2013 at 3:56 PM, Steven van Loef notifications@github.com wrote:
Last 2 characters of a link are not tappable if one emoji (or any other 2 byte unicode character) is used before the link. (see the example app.js in my fork of the code for some test strings that have this and other issues).
Reply to this email directly or view it on GitHub: https://github.com/dezinezync/NappUI/issues/2
Yes I can confirm the highlight issue as well, not that big of a deal but would be nicer if the whole link would be highlighted of course. I think I also saw sometimes that when links wrap to the next (probably last) line, the second part of the link is not tappable.
Hmm, yes, noticed that! Somehow, it doesn't happen when using a UITextView and setting the link attribute on the NSAttributedString with data detectors off.
Cheers, Nikh.
On Mon, Oct 7, 2013 at 4:16 PM, Steven van Loef notifications@github.com wrote:
Yes I can confirm the highlight issue as well, not that big of a deal but would be nicer if the whole link would be highlighted of course. I think I also saw sometimes that when links wrap to the next (probably last) line, the second part of the link is not tappable.
Reply to this email directly or view it on GitHub: https://github.com/dezinezync/NappUI/issues/2#issuecomment-25799142
Last 2 characters of a link are not tappable if one emoji (or any other 2 byte unicode character) is used before the link. (see the example app.js in my fork of the code for some test strings that have this and other issues).