search

df-mc / dragonfly

Minecraft Bedrock Edition server software written in Go
https://discord.gg/U4kFWHhTNR
MIT License
669 stars 150 forks source link

Item throwing doesn't work when not held #219

Closed Sandertv closed 1 year ago

Sandertv commented 3 years ago

When throwing an item out of the hotbar on mobile editions, you do not actually need to select the item in the hotbar. Dragonfly assumes this has to be done however, and rejects item dropping if the item dropped is not held in the hand. This is incorrect behaviour.

Sandertv commented 3 years ago

This has not yet been fixed by the commit mentioned above. This is difficult to fix if we don't fully handle inventory transactions (which we don't). As this issue is of very low significance, I'm going to give this the v? milestone. If Mojang ever finished their changes to the inventory system, this should be fixed automatically.

JustTalDevelops commented 1 year ago

https://github.com/pmmp/PocketMine-MP/blob/minor-next/src/network/mcpe/handler/InGamePacketHandler.php#L389-L409

This might be of use.