Checksum invalid or type unrecognised on habitat genpayload wizzard

df8oe / RS41HUP

RS41HUP - Firmware for Vaisala's RS41 for Amateur Radio use

GNU General Public License v2.0

43 stars 15 forks source link

Checksum invalid or type unrecognised on habitat genpayload wizzard #7

Closed zanco closed 6 years ago

zanco commented 6 years ago

Hi, for the last 6 months or so I get this error when I try to create a payload doc with this RS41HUP version.

Checksum invalid or type unrecognised. Tried xor crc16-ccitt fletcher-16 fletcher-16-256

I have no clue why this happens. Any help please ?

Thanks, Ben

df8oe commented 6 years ago

I have no idea, too. Checksum is calculated using CRC-16 and OVER ALL FILEDS (included RTTY comment - maybe that's the problem??). I have just tested - checksum is generated properly.

Best regards Andreas

ED6E0F17 commented 6 years ago

The checksum was broken by the commit: https://github.com/df8oe/RS41HUP/commit/1ca9174a91a3e0393b438552db53bc1db5cf2263

which removed a single "$" from the start of RTTY string without changing the offset in : https://github.com/df8oe/RS41HUP/blob/master/main.c#L234

df8oe commented 6 years ago

Many thanks. This was never intended - it was a typo.

Fixed now.