df8oe / UHSDR

SDR firmware and bootloader with configuration files for use with Eclipse, EmBitz and Makefile
Other
360 stars 189 forks source link

VSWR foldback protection only when min power available #1855

Closed innattar closed 4 years ago

innattar commented 4 years ago

While testing SSB transmit on the MCHF I kept having VSWR protection kick in (blinking TX). This would not happen during tune or if I used a 100% duty cycle mode like FM. After troubleshooting I realized this only happened when the transmit power level dropped. The UI code set precedent for not computing SWR (for display purposes) if a minimum forward power was not met. I took this concept and applied it to the VSWR foldback protection code. I tested this on an MCHF under the same conditions as before and had no issue with VSWR protection kicking in.

innattar commented 4 years ago

Sorry this is my first time collaborating on Github. This PR is meant to be stacked on top of https://github.com/df8oe/UHSDR/pull/1854. Also I should note that I chose to split this up since the two changes were not related and I thought it would be best to have two PRs.

Since that isn't in the main repo yet both commits are showing up in the commit list for this PR. I apologize for any confusion.

innattar commented 4 years ago

Thanks for merging #1854. I have rebase and pushed up this branch so it only includes the one change.