search

df8oe / UHSDR

SDR firmware and bootloader with configuration files for use with Eclipse, EmBitz and Makefile
Other
360 stars 189 forks source link

Create github action to build firmware during PR submittion #1909

Closed howard0su closed 3 years ago

howard0su commented 3 years ago

The firmware gets build during PR and push to the devel branch and upload as artifact.

rogerclarkmelbourne commented 3 years ago

Be aware of Github actions are actively being exploited to mine crypo currencies.

https://therecord.media/github-investigating-crypto-mining-campaign-abusing-its-server-infrastructure/

rogerclarkmelbourne commented 3 years ago

I'm not suggesting that there should not be an action to do this. I'm just making the admins aware of potential implications or enabling actions on a repo.

df8oe commented 3 years ago

Hi Roger, hi Howard,

thank you for your comments and ideas. We already have a working workflow for building all versions of needed firmware (mcHF, OVI40/F7 and OVI40/H7) so there is no need to have such a new function.

hogthrob commented 3 years ago

@howard0su: Hi, I appreciate the commit, especially as it is not clear how long Travis will be available to us as means for CI. Good job! However, as Andreas said, for the release we currently use a different system. So we will not have a direct use for the script as is. Not sure, though, why you closed the PR? Please comment on this. Thank you.

@rogerclarkmelbourne : That mining exploit is unfortunately only the tip of the ice berg if you ask me. Thanks for bringing this to our attention!

rogerclarkmelbourne commented 3 years ago

@hogthrob & @df8oe

No worries.

howard0su commented 3 years ago

I closed PR as I saw you have a travis-CI run.

I think action is also free to use and no additional work to do by the admin of the repo. You can see a demo run in my repo here: https://github.com/howard0su/UHSDR/actions

I will reopen it when I have all the functions that travis-CI has.

On Wed, Apr 7, 2021 at 5:20 PM Roger Clark @.***> wrote:

@hogthrob https://github.com/hogthrob & @df8oe https://github.com/df8oe

No worries.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/df8oe/UHSDR/pull/1909#issuecomment-814754741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3GRAM45UH5Z2C645V7IDTHQPUDANCNFSM42QGTWOA .

-- -Howard