search

df8oe / UHSDR

SDR firmware and bootloader with configuration files for use with Eclipse, EmBitz and Makefile
Other
356 stars 186 forks source link

Fix macro to ensure a comma at the end #1910

Closed howard0su closed 3 years ago

howard0su commented 3 years ago

Yes, agree if this is the way we want to go with. let me do it.

howard0su commented 3 years ago

sure. i will change it. but there are other inline function in this file is not static inline as well.

which version of gcc10 will require this? My local gcc works fine. howardsu@macpro mchf-eclipse % arm-none-eabi-gcc --version arm-none-eabi-gcc (GNU Arm Embedded Toolchain 10-2020-q4-major) 10.2.1 20201103 (release)

db4ple commented 3 years ago

Hi, it is the gcc 10 2020 q4, as now used in Travis. See #1896 (profiling.h) . The problem only appears if the compiler for whatever reason decides not to inline the code and this happens in multiple files. For the one-liner it probably never happens but it is easily avoided that it ever happens by adding static where appropriate. In fact inline extern is also an interesting option, but I think we don't need this here.

Anyways, appreciate that you followed the suggestions. Obviously it would have been easier to accept and then directly change the code but I thought, you would want to make a nice submission and would like to have your name in the "blame" history shown as you identified the improvement area.

howard0su commented 3 years ago

no problem. love to listen your suggestions.