dfacto-lab / serilog-sinks-file

Serilog file sinks duplicated for file rolling
Apache License 2.0
14 stars 9 forks source link

Roll on each process run #10

Closed carlopantaleo closed 3 years ago

carlopantaleo commented 3 years ago

I added the option rollOnEachProcessRun to LoggerConfiguration which, if set to false, mimics the behaviour of log4net. That is:

Those changes should not be breaking, because the option rollOnEachProcessRun is defaulted to true which is the previous behaviour. I also added some unit tests for completeness.

carlopantaleo commented 3 years ago

AppVeyor build with Visual Studio 2017 fails because tests target also .NET Core. The build on Ubuntu succeeds, indeed...

numito commented 3 years ago

Ok thank you AppVeyor error is because if donet3.1 target which is not compatible with visual studio 2017. I will restaure target donet2.2