search

dfacto-lab / serilog-sinks-file

Serilog file sinks duplicated for file rolling
Apache License 2.0
14 stars 10 forks source link

Rename repo to serilog-sinks-persistentfile #17

Open bartelink opened 2 years ago

bartelink commented 2 years ago

Given that the repo produces a .PersistentFile NuGet package, would it be possible to rename this repo to serilog-sinks-persistentfile ?

(External links redirect correctly if you do that; the only real risk is stuff in build scripts that derives names from the base path or such things)

numito commented 2 years ago

Well it has all the feature of persistent and non-persistent that's why I kept the name serilog-sinks-file. But that might be confusing. The only issue, is that renaming repos breaks all cloned projects.

bartelink commented 2 years ago

Ah, was unaware of the renaming 'breaking' clones (I've always seen git pushes to old names etc redirect happily), so if it's a problem it really doesn't matter that much...

I definitely get that it's a superset of the File functionality, but I'd say it's surprising that the README gives a different name; people might not at a glance that this is actually intended to be a superset that people use, as opposed to being a random clone that deviates to e.g. support some non-standard environment.

Please feel free to close this issue if you prefer not to rename as I can appreciate it's a finely balanced set fo tradeoffs

numito commented 2 years ago

Well it won’t break clones in GitHub as the rename will be propagated, but anyone who cloned on their computer should update their remote even if redirects work. Yes I understand your point and I agree. Ideally the project should be merged back in it’s original source repository. That was the initial intent.

Let me have a look at the impact. Not so many people have cloned it anyway.

Le 24 nov. 2021 à 15:08, Ruben Bartelink @.***> a écrit :

Ah, was unaware of the renaming 'breaking' clones (I've always seen git pushes to old names etc redirect happily), so if it's a problem it really doesn't matter that much...

I definitely get that it's a superset of the File functionality, but I'd say it's surprising that the README gives a different name; people might not at a glance that this is actually intended to be a superset that people use, as opposed to being a random clone that deviates to e.g. support some non-standard environment.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dfacto-lab/serilog-sinks-file/issues/17#issuecomment-977911963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZXCF5FYCVRYYUNC36U3H3UNTWWLANCNFSM5IU6GIJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

timmolter commented 1 month ago

it is indeed confusing. Github uses internal remapping if old URLs re used. So it's safe to change.