search

dfahlander / typeson-registry

The type registry for typeson
MIT License
6 stars 5 forks source link

fix: resizable array buffer close gh-37 #38

Closed Jack-Works closed 1 month ago

Jack-Works commented 1 month ago

close #37

brettz9 commented 1 month ago

Thanks for the report and PR! I hadn't seen your PR and started #39 . I've added a fix for the ArrayBuffer type too. But running into your same issue in CI for Node 18. The Node 22 issue is I think that mentioned at https://github.com/dfahlander/typeson-registry/issues/24#issuecomment-2227481762

If you want to review, I think we can nevertheless merge the changes, as I think they are indeed necessary.

brettz9 commented 1 month ago

The Node 18 failure was due to CI using an older version of Node. I've adjusted CI, though not sure if a bump in engines is needed too.

In any case, closing in favor of #39 . Thanks again!

Jack-Works commented 1 month ago

thanks! happy to see that fixed