dfaker / WebmGenerator

UI and Automation to cut, filter and join high quality webms, mp4s or gifs.
Mozilla Public License 2.0
517 stars 33 forks source link

Issue with subtitle handling #84

Closed ghost closed 2 years ago

ghost commented 2 years ago

I'd like to make webms of mkv files but sometimes the scene would look better without the subtitles in. Is there any way to disable them during editing that I am missing? Is it something that can be implemented in some way?

Anyway thanks for the awesome tool. Definitely the best out there I love it :)

ghost commented 2 years ago

I just noticed it strips subs automatically. Then I tried to mess around and try to include them. I got I need to use the subs filter and load .srt file I can extract from the video with WebmGenerator, but I dont know why it sets a wrong color and a wrong font size.

While I can set the color to what I want it to, the size doesn't change.. Am I doing something wrong?

Might be a bit braindead from me to ask, but what would be optimal is like a checkbox in the final rendering "Include subtitles" true or false and it puts them automatically in or not with the same color and size of the "original" font.

ghost commented 2 years ago

image

This is the issue I get: REALLY big subs that don't change with the fontsize and they got automatically set to yellow as color which I later modified.

image

Then I just noticed that it works correctly with this Demon Slayer video. Even fileSize 12 is the right one actually. Just had to put white as color.

Weird even tho the files are both from the same releaser (SubsPlease).

ghost commented 2 years ago

Tried another releaser for the issued videos but nothing. Still too big.

image

dfaker commented 2 years ago

The .srt files can occasionally contain directions to use larger or bold fonts, would you mind sharing the srt that produced this effect?

ghost commented 2 years ago

Tried a third anime just in case and it works. From another releaser too. image

Anyway the file that makes this error: image

Is this one (putting on catbox.moe because git doesnt accept it ( https://files.catbox.moe/y6rgw4.srt ). Keep in mind that it happened both with SubsPlease release, and AWS release, whose subs I put here ( https://files.catbox.moe/y6rgw4.srt ) and both the subs make the issue.

Let me know if there is anything I can do to help you

ghost commented 2 years ago

Just for the record I downloaded another "famous" tool and put the video inside, added sub filter and rendered and it came out as intended. The same video that produced the issues

dfaker commented 2 years ago

Yeah those subs have a hardcoded size in them:

<font face="Roboto Medium" size="52">

I'll see if there are any options for ignoring that other than editing the text of the .srt itself.

ghost commented 2 years ago

Thanks for investigating. I'll be waiting to hear from you about this or for a version release. And again. Thank's for the awesome tool :)

ghost commented 2 years ago

Another thing that may help you out:

I've just checked the .srt of Kimetsu No Yaiba EP ( https://files.catbox.moe/q2icl8.srt ) which works fine as you can see in the previous posts I made. And it has also some hard coded size but it seems to work fine even with that..?

<font face="Roboto Medium" size="26"><i>Rengoku!</i></font>

Not sure what may be happening here then

dfaker commented 2 years ago

it has also some hard coded size but it seems to work fine even with that..?

It's still hardcoding the size, it just so happens that 26 is a more suitable size for the video than the other file at 52.

ghost commented 2 years ago

I modified the srt file putting 26 and this is how it showed: webmGenerator_2022-08-1016-18-06

Then I modified subs file putting size equal as 12 and this is the result. A bit off-put compared to the video, but it shrinked. image

dfaker commented 2 years ago

Yes, that is completely as expected, I'll see what can be done to bring that into the control of the filter itself.

dfaker commented 2 years ago

With the most recent release the "Extract .srt subtitles from video file" option will strip those hardcodings from a video or existing subs file.