dfaker / WebmGenerator

UI and Automation to cut, filter and join high quality webms, mp4s or gifs.
Mozilla Public License 2.0
505 stars 33 forks source link

Stream Copy produces corrupted video when joining multiple subclips #91

Closed LolicoreExpress closed 1 year ago

LolicoreExpress commented 2 years ago

Joining multiple subclips together using the Stream Copy feature seems to produce a corrupted video. Specifically at the transition between each clip. Have a look. https://user-images.githubusercontent.com/29737484/191583502-493aec26-f79a-40d2-9fdc-ad666309e0c9.mp4

dfaker commented 1 year ago

Yes this is expected, it's a matter of luck (or rather the lack of it) as to how bad this is, I'd not recommend using multiple clips in stream copy unless you feel sufficiently lucky.

LolicoreExpress commented 1 year ago

Oh okay haha. Too bad, I was starting to like this feature more and more despite this 😅

dfaker commented 1 year ago

It's fast but it doesn't escape the usual 'lossless' downsides of possible joining artefacts and clamping to keyframes.

https://github.com/mifi/lossless-cut is very much the gold standard for lossless slicing.

LolicoreExpress commented 1 year ago

I see. Oh well, can't be helped then.

LolicoreExpress commented 1 year ago

Lol for some reason my brain did not register the link you put. Thanks for the recommandation I'll check it out. I guess this can be closed then ^^