Port to GTK3 - Githubissues

dfandrich / gpscorrelate

C program to match GPS tracks to photographs, and store the matches in the EXIF data in the photographs.

https://dfandrich.github.io/gpscorrelate/

GNU General Public License v2.0

29 stars 8 forks source link

Port to GTK3 #1

Closed sikmir closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 192

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.203%

Totals
Change from base Build 185:	0.0%
Covered Lines:	893
Relevant Lines:	938

Thanks for the patch! I'm not really up on GTK (which is why this hasn't been done yet) but is there any reason to keep GTK 2 support in 2019? Since this isn't a library there will be nothing else depending on it still being compatible with GTK 2.

sikmir commented 5 years ago

but is there any reason to keep GTK 2 support in 2019?

As for me, there is no reason. But... just in case, that's not a big deal. Anyway, it's up to you to skip GTK2 support.

sikmir commented 5 years ago

@dfandrich Can we land this PR?

dfandrich commented 5 years ago

Thanks!

dfandrich / gpscorrelate

Port to GTK3 #1

Pull Request Test Coverage Report for Build 192

💛 - Coveralls