dfannin
commented
3 years ago This library was developed on Arduino atmel based boards (Nano, Mega, etc), The Adafruit Feather M4 is a SAM51-based board, so I expect that you'll run into a number of issues. YMMV.
Issue 1:
On the first issue above, the SPI library function call SPISettings() is #declared differently for SAM51 boards. SPISettings(uint32_t clock, BitOrder bitOrder, uint8_t dataMode) <- SAM51
BitOrder is an enum declared in the adafruit/hardware/samd/1.7.5/cores/arduino/wiring_constants.h file and doesn't allow this to be converted to uint8_t (unsigned char) type.
What you can do is try changing:
file: adf4351.h, line 55:
ADF4351(byte pin, uint8_t mode, unsigned long speed, uint8_t order ) ;
to
ADF4351(byte pin, uint8_t mode, unsigned long speed, BitOrder order ) ;
and
file: adf4351.h, line 45:
ADF4351::ADF4351(byte pin, uint8_t mode, unsigned long speed, uint8_t order ) {
to
ADF4351::ADF4351(byte pin, uint8_t mode, unsigned long speed, BitOrder order ) {
The Constants MSBFIRST and LSBFIRST are the same, so that should resolve this issue.
Issue 2:
For the dtostrf (double to string format) function call, that is also missing due to using this on SAM51, as this is included via the "avr/dtostrf.h" include, which is not added for non-AVR boards. Googling for this indicates that you can try adding it for SAM51 boards by adding the following include statement in adf4351.h.
#include <stdlib_noniso.h>
I don't have a way to test either of these, so if you get to work, let me know, and I'll update the library or send me a pull request.
E63S4Me
Somewhat of a noob at copying in libraries and other code beside the example sketches. I thought I had followed the instructions but am getting the errors below when I attempt to compile the example4351 sketch. Changed my username to xxxxx but other than that just copy/pasted the text from the Arduino IDE.
Any help would be greatly appreciated.
Arduino: 1.8.16 (Mac OS X), Board: "Adafruit Feather M4 Express (SAMD51), Enabled, 120 MHz (standard), Small (-Os) (standard), 50 MHz (standard), Arduino, Off"
In file included from /Users/xxxxx/Documents/Arduino/libraries/adf4351-master/src/adf4351.h:12, from /Users/xxxxx/Documents/Arduino/libraries/adf4351-master/src/adf4351.cpp:51: /Users/xxxxx/Library/Arduino15/packages/adafruit/hardware/samd/1.7.5/libraries/SPI/SPI.h:66:40: note: initializing argument 2 of 'SPISettings::SPISettings(uint32_t, BitOrder, uint8_t)' 66 | SPISettings(uint32_t clock, BitOrder bitOrder, uint8_t dataMode) { |
~~~^~/Users/xxxxx/Documents/Arduino/libraries/adf4351-master/src/adf4351.cpp: In member function 'int ADF4351::setf(uint32_t)': /Users/xxxxx/Documents/Arduino/libraries/adf4351-master/src/adf4351.cpp:156:3: error: 'dtostrf' was not declared in this scope 156 | dtostrf(PFDFreq, cntdigits + 8 , 3, tmpstr) ; | ^~~ exit status 1 Error compiling for board Adafruit Feather M4 Express (SAMD51).This report would have more information with "Show verbose output during compilation" option enabled in File -> Preferences.