search

dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Ensure every puppet run does not unzip the odl #102

Closed vpramo closed 8 years ago

vpramo commented 8 years ago

Every time puppet runs, the odl zip was getting downloaded unzipping and restarting services. To ensure this doesnt happen, we need to add a root_dir in the archive provider .

This will ensure that multiple puppet runs will not cause any service restarts

dfarrell07 commented 8 years ago

@vpramo thanks for the PR! Sorry for the delay, I'm still trying to understand exactly what this does. Restating what I'm understanding from the commit message, this is meant to make the tarball extraction process idempotent? If you could give an example that would help me quickly understand/merge. Else I'll take another dive early next week (when I get home, traveling at the moment). Thanks again!

vpramo commented 8 years ago

@dfarrell07 hey sorry for the bad commit message, well basically during each and every puppet run, the tarball was getting unzipped and extracting all the files and since its dependent on the service, it basically will restart the ODL service.

You can refer to this Issue raised in puppet-archive

https://github.com/camptocamp/puppet-archive/issues/55

dfarrell07 commented 8 years ago

@vpramo Okay, cool, that makes sense. Thanks!