search

dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Adds security group mode configuration #108

Closed trozet closed 7 years ago

trozet commented 7 years ago

Security grouop mode defaults to stateful in Boron release. Red Hat based systems less than 7.3 release are unable to use stateful. This patch detects those OS types and fallsback to 'learn' mode. The mode is also configurable as a new param to the opendaylight class.

Signed-off-by: Tim Rozet tdrozet@gmail.com

dfarrell07 commented 7 years ago

Thanks for the tests and docs btw

dfarrell07 commented 7 years ago

Some of the rspec tests are failing:

error during compilation: Evaluation Error: Unknown variable: '::opendaylight::params::sg_mode'. at /home/travis/build/dfarrell07/puppet-opendaylight/spec/fixtures/modules/opendaylight/manifests/init.pp:49:26 on node testing-docker-bb5436e9-4ebd-4ca0-9881-6efde2df1e83.ec2.internal

https://travis-ci.org/dfarrell07/puppet-opendaylight/jobs/175830787#L1026

dfarrell07 commented 7 years ago

Also, Ruby 1.9.3 is failing with:

Gem::InstallError: json_pure requires Ruby version ~> 2.0.

https://travis-ci.org/dfarrell07/puppet-opendaylight/jobs/175830769#L198

dfarrell07 commented 7 years ago

We're not relying on rspec via Travis CI at the moment, see #109. @trozet has tested this in external OOO CI and says it works.