search

dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Update Ruby version #120

Closed srisankethu closed 7 years ago

srisankethu commented 7 years ago

Fixes https://github.com/dfarrell07/puppet-opendaylight/issues/119

dfarrell07 commented 7 years ago

Ah, I see this is just a PR for Ruby versions. Maybe you want to do #119 in two commits, one for Ruby and one for Puppet? That's fine with me I guess. Let's do the 2.2.6 upgrade here tough https://www.ruby-lang.org/en/downloads/

srisankethu commented 7 years ago

@dfarrell07 I have added newer 2.2.6 version and removed the exceptions. Added new puppet versions too.

srisankethu commented 7 years ago

@dfarrell07 ERRORS ALERT! I will fix it in a separate patch. Anyway, I am trying to improve the test-coverage.

dfarrell07 commented 7 years ago

@srisankethu ACK, thanks :+1:

srisankethu commented 7 years ago

@dfarrell07 This is strange! The tests are passing locally when I am executing bundle exec rake test for Ruby: 2.3.1 and Puppet: 4.8.1 but failing in the travis checks :(

dfarrell07 commented 7 years ago

:+1: