search

dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Removing the work around jolokia and it's config file(s) #132

Closed jluhrsen closed 7 years ago

jluhrsen commented 7 years ago

the current method for bringing jolokia in to OpenDaylight is just to install the feature "odl-jolokia". This is probably something to be done on a use-case basis and not added to the default features list.

Signed-off-by: Jamo Luhrsen jluhrsen@redhat.com

jluhrsen commented 7 years ago

BTW, there is other "clusering" stuff in puppet-opendaylight that might not be needed. the recommended way to configure clustering is with the config scripts shipped with the ODL distro. those scripts do all the work with the akka, etc files. but, if the consumers of puppet-opendaylight are not using those config scripts at this point, removing other things here could break them.

also, it should be noted that removing these jolokia steps/files/etc will not break clustering. it's an additional feature needed to turn on some things that external tools (like our cluster monitor, or CSIT) use. but, as far as HA working, it will still be fine if jolokia is not installed.

dfarrell07 commented 7 years ago

the recommended way to configure clustering is with the config scripts shipped with the ODL distro

I guess we should consume these scripts in puppet-odl and ansible-odl to do clustering config.

dfarrell07 commented 7 years ago

Looks good, passing rspec and beaker. Thanks @jluhrsen!