search

dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Fix idempotency around systemd restart #137

Closed mwhahaha closed 7 years ago

mwhahaha commented 7 years ago

Switch the exec to reload the systemd daemon to only occur when the puppet module updates the systemd unit file.

dfarrell07 commented 7 years ago

I had to read the docs, but this makes sense and seems like a clearly better behavior.

This is passing bundle exec rake acceptance_dock and bundle exec rake acceptance_vm for me.

We're excluding this exec from test coverage in spec/spec_helper.rb. We have a Trello card to track cleaning up those exceptions, adding tests where possible. Additional tests (some sort of idempotency sysd restart Beaker check?) would be welcome, but since we're already ignoring the code it's non-blocking imho.

Thanks for the PR! :+1: