dfarrell07 / puppet-opendaylight

Moved: https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=tree
12 stars 15 forks source link

Adds ability to configure ODL user/pass #140

Open trozet opened 7 years ago

trozet commented 7 years ago

Signed-off-by: Tim Rozet tdrozet@gmail.com

dfarrell07 commented 7 years ago

@trozet bundle exec rake sanity is showing some relevant-seeming errors for me

https://pastebin.com/vrMM8jdq

dfarrell07 commented 7 years ago

We need this bugfix before Beaker test will pass

https://git.opendaylight.org/gerrit/#/c/54350/

dfarrell07 commented 7 years ago

We have a patch to not include ODL's version in the JAR

https://git.opendaylight.org/gerrit/#/c/54388/

dfarrell07 commented 7 years ago

Still failing for me https://pastebin.com/3R1WAYVS

dfarrell07 commented 7 years ago

Talked to @trozet, both thought it would be good to re-spin RPM (to be totally sure @vorburger's change is in the snapshot) and test again.

We have a snapshot build from today in 6-testing

http://cbs.centos.org/repos/nfv7-opendaylight-6-testing/x86_64/os/Packages/opendaylight-6.0.0-0.1.20170413snap4880.el7.noarch.rpm

And bundle exec rake sanity (which uses 6-testing) is still failing

https://pastebin.com/Xs3dLRLx

I noticed this line in the log

 Error: /Stage[main]/Opendaylight::Config/Odl_user[admin]: Could not evaluate: Execution of '/usr/bin/java -jar /opt/opendaylight/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar --dbd /opt/opendaylight -l' returned 1: Error: Unable to access jarfile /opt/opendaylight/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar

Which pointed me to this line in the PR

lib/puppet/provider/odl_user/idm.rb:10: java('-jar', "#{odl_path}/bin/aaa-cli-jar-0.5.0-SNAPSHOT.jar", '--dbd', odl_path, *args

We need to update the filename to not include a version now that @vorburger's change to not include a version in the JAR is merged/shipping.

trozet commented 7 years ago

@dfarrell07 this should work now, it passes docker acceptance with carbon. We should probably update the Rakefile to remove older versions for the acceptance testing in puppet-opendaylight master branch

dfarrell07 commented 7 years ago

@trozet I have a new dev laptop (old one crashed so hard RH IT gave me my upgrade early as replacement), on which Docker+Beaker consistently crashes my kernel. :( Just running containers with Docker is fine, but something like bundle exec rake cent_6test_dock makes things crash and burn.

Running Beaker in VMs, I'm hitting this issue

https://tickets.puppetlabs.com/browse/BKR-972

It was supposed to be fixed in this PR

https://github.com/puppetlabs/beaker/pull/1313

Which is in 3.14.0 (the latest release, release I'm using)

dfarrell07 commented 7 years ago

@trozet can you send this to the new ODL-manged repos? Should just require adding a new remote, setting up git-review and pushing.

https://git.opendaylight.org/gerrit/gitweb?p=integration/packaging/puppet-opendaylight.git;a=summary

trozet commented 7 years ago

@dfarrell07 done: https://git.opendaylight.org/gerrit/#/c/56028/