dfaust / soundkonverter

soundKonverter is in maintenance mode, PRs are welcome.
https://github.com/dfaust/soundkonverter/wiki
98 stars 26 forks source link

Character # (hash) in input filename garbles output filename #63

Open marcelpaulo opened 6 years ago

marcelpaulo commented 6 years ago

When an input file name contains the character # (hash), the output filename is garbled. I'm trying to convert these flac files to mp3:

/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/01. Flautando.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/02. Jazz Cantata I, II, III.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/03. Jazz Cantata IV.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/04. Jazz Cantata V, VI, VII.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/05. Trope a Saint-Trop.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/06. Osymetrios I.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/07. Le palais ideal I, II, III.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/08. Le palais ideal IV.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/09. Le palais ideal V, VI, VII.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/10. Jazz et jazz.flac
/home/paulo/stage/cd/#097. Andre Hodeir - Jazz & Jazz/11. Osymetrios II.flac

When I load them on soundkonverter, here's the result: screenshot_2018-01-27_16-59-05 It looks as though all characters after # are ignored, as in a shell comment.

I compiled soundkonverter from source, version aa20a5ad025cd30adaec16989ca4f8868da69f72, following the wiki instructions. I'm running an up-to-date Xubuntu 17.10.

iwismer commented 6 years ago

I have the same issue, all files with a '#' in the name simply fail because it cannot find the file because it stops reading the file name at the #. I have attached relevant logs. skLog1.txt skLog2.txt skLog3.txt skLog4.txt image I am running Arch with kernel 4.15.7 and soundKonverter 3.0.1-1 installed from the Arch package repo

WKoster commented 5 years ago

Still not working in version 3.0.1-1

utack commented 5 years ago

Can someone check for "?"
It also does not seem to work for me

barrar commented 3 years ago

Using 3.0.1 I am having an issue with input files that have # in the filename or folder name. For example if the filename was song #1.mp3 then the filename passed to lame --decode becomes song.mp3 and the file of course cannot be found.

Identifier: file:///tank/songfolder%20#1/songfilename%231.mp3
Log ID: 453316881
    Possible conversion strategies:
        mp3 ➝ wav (lame), wav ➝ opus (Opus Tools)
        mp3 ➝ wav (FFmpeg), wav ➝ opus (Opus Tools)
        mp3 ➝ wav (SoX), wav ➝ opus (Opus Tools)
        mp3 ➝ wav (MPlayer), wav ➝ opus (Opus Tools)
        mp3 ➝ wav (lame), wav ➝ opus (FFmpeg)
        mp3 ➝ opus (FFmpeg)
        mp3 ➝ wav (FFmpeg), wav ➝ opus (FFmpeg)
        mp3 ➝ wav (SoX), wav ➝ opus (FFmpeg)
        mp3 ➝ wav (MPlayer), wav ➝ opus (FFmpeg)
File system type: zfs

Executing next step
Decoding
    /usr/bin/lame --decode "/tank/songfolder " "/tmp/soundkonverter_temp_convert_453316886_0.wav"
    System error.
    Could not open sound file "/tank/songfolder ".
    Could not find "/tank/songfolder ".
    Can't init infile '/tank/songfolder '
    Conversion failed. Exit code: 255
WKoster commented 3 years ago

I just bit the bullet and remove the #'s altogether using:

find . -print | grep "#" | while read file do echo Found: $file mv "$file" "echo $file | sed 's/#//'" done

before running soundkonverter

barrar commented 3 years ago

Thanks @WKoster that'll do nicely