search

dfaust / soundkonverter

soundKonverter is in maintenance mode, PRs are welcome.
https://github.com/dfaust/soundkonverter/wiki
98 stars 26 forks source link

Make translations work again #84

Closed mihkel-t closed 4 years ago

mihkel-t commented 4 years ago

Gettext domain was not set, so the translations weren't detected. Added the domain. The i18n calls no longer like to have .arg() appended. Replaced those.

mihkel-t commented 4 years ago

What I couldn't get to show up localized was the About dialog & CLI arguments. The About dialog still doesn't show the contributors, either.

dfaust commented 4 years ago

Thank you very much. I looked through the changes and they look good, but to be honest I haven't tested it.