dfd-tud / deda

https://dfd.inf.tu-dresden.de
GNU General Public License v3.0
1.57k stars 92 forks source link

known exceptions #21

Closed ukos-git closed 4 years ago

ukos-git commented 4 years ago

I have a Samsung printer (CLP 320) and it does not seem to produce yd. Is there a list of known limitations of the script?

steps taken

I have printed the calibration.pdf, scanned that in 600dpi color to pnm, converted to losless tiff and analyzed using deda. I could drop the raw scan somewhere, if you are interested in analysing it.

▶ deda_extract_yd scan/SnapScanLossless00001.tiff                      
No tracking dot pattern found :-) (0.000001 yellow dots per inch)

then the script fails with stack trace

Traceback (most recent call last):
  File "/home/matthias/.local/bin/deda_extract_yd", line 10, in <module>
    sys.exit(main())
  File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 888, in <lambda>
    main = lambda: Main()()
  File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 91, in __call__
    noCrop=self.args.no_crop)
  File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 846, in __init__
    self.cleanDotPositions(rotation=not noRotation,crop=not noCrop)
  File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 673, in cleanDotPositions
    self.rotation = -self.getAngle(self.dots)
AttributeError: 'YellowDotsXposer' object has no attribute 'dots'
timojuez commented 4 years ago

Hi Matthias,

mainly the printers do not produce yellow tracking dots if they are not being made in Japan or USA. This is the case for your printer. You can also check whether the scanner uses some threshold for the white paper and accidently removes the dots.

Am Mo., 20. Jan. 2020 um 16:04 Uhr schrieb matthias < notifications@github.com>:

I have a Samsung printer (CLP 320) and it does not seem to produce yd. Is there a list of known limitations of the script? steps taken

I have printed the calibration.pdf, scanned that in 600dpi color to pnm, converted to losless tiff and analyzed using deda. I could drop the raw scan somewhere, if you are interested in analysing it.

▶ deda_extract_yd scan/SnapScanLossless00001.tiff

No tracking dot pattern found :-) (0.000001 yellow dots per inch)

then the script fails with stack trace

Traceback (most recent call last):

File "/home/matthias/.local/bin/deda_extract_yd", line 10, in

sys.exit(main())

File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 888, in

main = lambda: Main()()

File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 91, in call

noCrop=self.args.no_crop)

File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 846, in init

self.cleanDotPositions(rotation=not noRotation,crop=not noCrop)

File "/home/matthias/.local/lib/python3.7/site-packages/libdeda/extract_yd.py", line 673, in cleanDotPositions

self.rotation = -self.getAngle(self.dots)

AttributeError: 'YellowDotsXposer' object has no attribute 'dots'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dfd-tud/deda/issues/21?email_source=notifications&email_token=ABCBCDZ64L5EGPJWGDYSVNLQ6W4OTA5CNFSM4KJFUJKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHMIN5A, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCBCDYKBTDV54Y5T6VOOALQ6W4OTANCNFSM4KJFUJKA .

ukos-git commented 4 years ago

Thank you. That is viable information. Should that be added to the Readme.md?

timojuez commented 4 years ago

Thank you. The second info is somewhere in the Readme under “troubleshooting” and the first info is only true for all printers I know. But I have not analysed all South Korean printers ;)