search

dfdx / Boltzmann.jl

Restricted Boltzmann Machines in Julia
Other
67 stars 27 forks source link

Fixing PCD implementation. #48

Closed fissoreg closed 6 years ago

fissoreg commented 6 years ago

Fixing #47.

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.03%     
==========================================
  Files           7        7              
  Lines         434      435       +1     
==========================================
+ Hits          373      374       +1     
  Misses         61       61
Impacted Files Coverage Δ
src/rbm.jl 87.32% <100%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0625ed0...9f701be. Read the comment docs.

dfdx commented 6 years ago

Huh! It's quite an old bug, and I can't figure our how I came to it. Anyway, nice that you've noticed it, thanks! The fix also looks correct, so merging it.