search

dfdx / Boltzmann.jl

Restricted Boltzmann Machines in Julia
Other
67 stars 27 forks source link

Ready for Julia 1.0 #50

Closed fissoreg closed 6 years ago

fissoreg commented 6 years ago

Fixed errors on Julia 1.0.

dfdx commented 6 years ago

Woohoo! Cool that you are working on this! Everything in the code looks good, could you please also update .travis.yml to use Julia 1.0 so we could see build status?

fissoreg commented 6 years ago

Done! :)

At a certain point I could also try to add a Project.toml file, which should be the standard solution with the new package manager...

dfdx commented 6 years ago

I haven't been tracking changes to package manager for a while, but the last time I did the recommendation was not to add Project.toml until an official PR arrives. Anyway, if it works without that file, let's keep it as is.

It seems like absence of Project.toml also causes Travis to fail the build. I think we just need to copy .travis.yml from some well-ported to Julia 1.0 package to fix it during this transition period. Anyway, it's entirely different task that we can do later (maybe even when the dust settles and all the packages get their Project.toml). So I'm merging this PR. Thanks again for the update!