dfdx / NaiveBayes.jl

Naive Bayes classifier
MIT License
25 stars 19 forks source link

Updated for Julia v"1.0.0" #36

Closed asbisen closed 6 years ago

asbisen commented 6 years ago

Cleaned up the code such that it works on Julia 1.0.0. All tests are passing. This version will no longer work with VERSION < v"0.7.0"

asbisen commented 6 years ago

OSX Builds in travis are failing (timeout?) at installing HDF5. On my mac laptop it's taking over 1hr to build HDF5. We will need to find a way to keep travis not timeout in order to complete osx build successfully.

codecov-io commented 6 years ago

Codecov Report

Merging #36 into master will increase coverage by 7.41%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   90.65%   98.06%   +7.41%     
==========================================
  Files           6        6              
  Lines         214      155      -59     
==========================================
- Hits          194      152      -42     
+ Misses         20        3      -17
Impacted Files Coverage Δ
src/gaussian.jl 100% <ø> (+8.33%) :arrow_up:
src/nbtypes.jl 100% <ø> (+11.9%) :arrow_up:
src/hybrid.jl 95.58% <100%> (-0.25%) :arrow_down:
src/common.jl 100% <100%> (+15.15%) :arrow_up:
src/datastats.jl 100% <100%> (+6.66%) :arrow_up:
src/multinomial.jl 100% <100%> (+25%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 486e447...e3acedd. Read the comment docs.

dfdx commented 6 years ago

I remember Travis announced reduction of Mac machines for open-source projects because of their high cost, so anyway many builds now fail while waiting for a slot to run. Let's keep .travis as is then.

Thanks for updating the package!