change `string(...)` calls to `sprint(show, ...)` - Githubissues

dfdx / Umlaut.jl

The Code Tracer

MIT License

32 stars 6 forks source link

change `string(...)` calls to `sprint(show, ...)` #10

Closed cscherrer closed 2 years ago

cscherrer commented 2 years ago

There are some differences in available methods between string and println. This PR changes calls to string(foo) to sprint(show, foo), which seems to cover more cases. Along the way, there are just a few other minor changes. More specifically,

string(T) => sprint(show, T)
"$v" => sprint(show, v)
println(io, " $op") => println(io, " ", op) (I've read that the latter is usually faster, though I haven't checked this case)
map(string, loop.parent_inputs) => map(s -> sprint(show, s), loop.parent_inputs)

dfdx commented 2 years ago

Today I learned the new sprint(show, ...) trick :smile: Thanks!