search

dfdx / Umlaut.jl

The Code Tracer
MIT License
32 stars 6 forks source link

Fixes for 1.9 #31

Closed willtebbutt closed 1 year ago

willtebbutt commented 1 year ago

Sorry for another PR @dfdx . Currently Umlaut doesn't work on 1.9 because CompilerPluginTools doesn't work on 1.9. @Roger-luo pointed out to me that things have changed quite a bit in 1.9, and there's now the helpful code_ircode function in Base, which does exactly what we want here (I think).

I chose the optimize_until kwarg based on the optimisation levels available here, and which level made the tests pass (I think the one I've chosen must be equivalent to the no_pass setting for CompilerPluginTools.

dfdx commented 1 year ago

I've been terrified by the idea of investigating the low-level changes in Julia 1.9. Thanks a lot for doing it instead of me! :smile: