dfe-analytical-services / analysts-guide

A static website to hold guidance, helpful links and code examples for analysts working in DfE.
https://dfe-analytical-services.github.io/analysts-guide/
MIT License
3 stars 2 forks source link

fixing 2 broken links #30

Closed jen-machin closed 10 months ago

jen-machin commented 10 months ago

Fixed 2 broken links in the SQL section: https://dfe-analytical-services.github.io/analysts-guide/learning-development/sql.html#how-to-work-with-sql

The first link was an easy replacement but I'm not sure about the 2nd link as the wording seems to have changed? The original link was https://dfe-analytical-services.github.io/analysts-guide/RAP/rap.html#Single_publication_production_script and I swapped it for https://dfe-analytical-services.github.io/analysts-guide/RAP/rap-statistics.html#whole-publication-production-scripts as it was the closest thing I could find. Is that right?

cjrace commented 10 months ago

Fixed 2 broken links in the SQL section: https://dfe-analytical-services.github.io/analysts-guide/learning-development/sql.html#how-to-work-with-sql

The first link was an easy replacement but I'm not sure about the 2nd link as the wording seems to have changed? The original link was https://dfe-analytical-services.github.io/analysts-guide/RAP/rap.html#Single_publication_production_script and I swapped it for https://dfe-analytical-services.github.io/analysts-guide/RAP/rap-statistics.html#whole-publication-production-scripts as it was the closest thing I could find. Is that right?

Yep - this is right. We did debate the wording a bit at the time, it used to be single publication production script but that we felt was confusing and decided that 'whole' was clearer.

Cloned and built locally on this branch, both links work as expected so happy for this to get merged in 👍