dfe-analytical-services / dfeR

Common R tasks in the Department for Education (DfE)
https://dfe-analytical-services.github.io/dfeR/
GNU General Public License v3.0
8 stars 2 forks source link

Add get sql function #68

Closed cjrace closed 3 months ago

cjrace commented 4 months ago

Brief overview of changes

Add a get_clean_sql function to resolve #55, and details on code coverage setup to resolve #53.

This increases the package version to 0.2.0.

Why are these changes being made?

This function is used across lots of DfE projects already. Other bits of tidy up to resolve known issues with documentation.

Detailed description of changes

Updates to contributing page:

Updates to package documentation:

Added get_clean_sql() function, documentation and tests. Includes a sample SQL script to test with.

Added vignette for connecting to SQL to give more user friendly context for get_clean_sql().

Bumping package version to 0.2.0 for this and #59.

Added note to README pointing to the reference documentation for the package.

Additional information for reviewers

  1. Use the following line to preview package documentation updates locally:
devtools::build_site()
  1. I will squash the commits when merging as I got into a slight mess with git rebase conflicts that seems to have duplicated commits in the commit history.

  2. I'll reflect any changes here in https://github.com/dfe-analytical-services/analysts-guide/pull/43 to update the relevant section of the Analysts' Guide.

Issue ticket number/s and link

55, #53.

cjrace commented 4 months ago

Add SQL functions into dfeR