search

dfe-analytical-services / dfeshiny

R package containing preferred methods for creating official DfE R Shiny dashboards
https://dfe-analytical-services.github.io/dfeshiny/
GNU General Public License v3.0
4 stars 1 forks source link

Improve error around the repo_name argument in support_panel() #29

Closed cjrace closed 6 months ago

cjrace commented 6 months ago

Making it more explicit in the documentation and error message why the repo_name field is erroring.

cjrace commented 6 months ago

One thought I had is whether we should rename the argument from repo_name to repo_url to help make it clearer. Though wary of how much this might be a breaking change anyone who has adopted it - @rmbielby, what do you think?

rmbielby commented 6 months ago

One thought I had is whether we should rename the argument from repo_name to repo_url to help make it clearer. Though wary of how much this might be a breaking change anyone who has adopted it - @rmbielby, what do you think?

It's not used too widely so far, so we could probably fairly easily go round and do the updates. And it'll give a pretty clear error when it does break.

rmbielby commented 6 months ago

Just added some fixes to the links as they were all broken from us trying to meet line-length constraints!