dfe-analytical-services / dfeshiny

R package containing preferred methods for creating official DfE R Shiny dashboards
https://dfe-analytical-services.github.io/dfeshiny/
GNU General Public License v3.0
4 stars 1 forks source link

lintr action is incorrectly flagging missing bindings #31

Open cjrace opened 4 months ago

cjrace commented 4 months ago

I've noticed on PRs that the lintr workflow seems to be incorrectly flagging bindings as missing, when they're clearly imported in the scripts. Has happened on #3.

image

Recreating it locally seems like it's missing a step in the workflow. If you run devtools::load_all() before running lintr::lint_package() it seems to fix it.

Would be good to resolve / fix to clear out the clutter it can bring, as some of these functions like tags() can use many many times across the package.

cjrace commented 1 month ago

I think this may be fixed by #41