Closed cjrace closed 4 weeks ago
Some of the examples end up inside a box with a scrollbar on the documentation site - is there any way around this?
![]()
Some of the examples end up inside a box with a scrollbar on the documentation site - is there any way around this?
Ah yeah, that was my bad, I forgot to wrap the example in a way that stopped it actually running, should be better now?
I've added a single example of how to use the cookies functions in a minimal shiny app that we can reuse across the documentation for all of our cookies family of functions. Main change here is in the cookies.R script - expand the diff there to review
While doing so I also took the liberty of adding in more default arguments so that analysts don't need to add as much code, so I've made the defaults what was suggested and then removed those arguments from the examples to encourage analysts to just keep the defaults.
reactive(input$cookies_input)
arguments too but they wouldn't work as defaults only and seemed to need to be explicit, so I've left those in the server fileAdditional notes:
41 adds a GitHub action that is now required for all PRs to main, this isn't on this branch so I'll just force a merge over that if this PR is approved before that one (if it's not then I'll be updating this branch to have it in once that gets to main)
lintr
notes, expecting them to be resolved in #41 separately so ignoring them intentionally here