dfe-analytical-services / eesyapi

An R package with useful utility functions for connecting to, and processing data from, the DfE's explore education statistics API.
https://dfe-analytical-services.github.io/eesyapi/
Other
1 stars 0 forks source link

Add better test coverage on query functions #27

Open cjrace opened 2 months ago

cjrace commented 2 months ago

Is your feature request related to a problem? Please describe.

Currently we don't have great test coverage of how fully a data set is retrieved.

Describe the solution you'd like

We have some easy wins here by making use of the direct CSV downloads or the CSV endpoint of the API (soon to be added) to compare a full CSV against the parsed paginated response.

Describe alternatives you've considered

Nothing else so far.

Additional context

Could use something like waldo to compare the whole data frame, though would need to consider ordering if doing this.