search

dfe-analytical-services / eesyapi

An R package with useful utility functions for connecting to, and processing data from, the DfE's explore education statistics API.
https://dfe-analytical-services.github.io/eesyapi/
Other
1 stars 0 forks source link

Tidy up parsing into a single response_parse function #58

Open cjrace opened 1 month ago

cjrace commented 1 month ago

Is your feature request related to a problem? Please describe.

Currently we have post_dataset() and get_dataset() both doing parsing independently, to reduce duplication and streamline our functions a bit for easier testing and maintenance we should break out a separate response_parse() eske function.

Describe the solution you'd like

A new function that handles the parsing for both post and get functions.

Describe alternatives you've considered

None, might be other approaches too.

Additional context

GitHub conversation on PR about this https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121

https://github.com/dfe-analytical-services/eesyapi/pull/54/files#r1813192121