Unit testing LA Level functions - Githubissues

dfe-analytical-services / local-authority-interactive-tool

Local Authority Interactive Tool

https://department-for-education.shinyapps.io/local-authority-interactive-tool/

MIT License

1 stars 0 forks source link

Unit testing LA Level functions #12

Closed JT-39 closed 2 months ago

JT-39 commented 2 months ago

Pull request overview

To add unit tests for all the functions that were built whilst the LA Level page was being designed in Azure DevOps.

Pull request checklist

Please check if your PR fulfills the following:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Tests have been run locally and are passing (shinytest2::test_app())
[x] Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

There are no unit tests (see the linked issue regarding no unit tests).

What is the new behaviour?

Unit tests exist, with hopefully good overage. The plotting functions in fn_plotting.R still need to be fully tested.

Anything else

May need a reviewer to check the quality of tests.

JT-39 commented 2 months ago

This needs to be revisited to finish adding tests for the plotting functions in fn_plotting.R.