This is the development of the Regional Level page of LAIT.
There has also been significant improvements made to the rest of the app.
Pull request checklist
Please check if your PR fulfills the following:
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Tests have been run locally and are passing (shinytest2::test_app())
[x] Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())
What is the current behaviour?
The app does not include the Regional Level page of LAIT. There are also several issues that need addressing, such as incorrect rankings, missing formatting, styling of the app and a lot more.
What is the new behaviour?
The full functionality (bar the bar charts) of the Regional Level Page of LAIT has been replicated. This includes all those listed in the Regional Level Page issue.
There have also been a number of other improvements:
Prettifying the chart y axes
Now only one England (update in data)
Decimal places now set (update in data)
Horizontal y-axis label
Format date as MM-YY for the last/next updated
Ensured that if no polarity - then no rank and QB
Make link to data open in a new tab (using dfeshiny::external_link()
Ordered tooltip by descending y-axis value
Fixed an incorrect join of statistical neighbour onto LAs in the global.R (was right_join(), should have been left_join())
NAs now showing in data tables
Chart and legend ordering sorted
Using new {dfeshiny} cookies functions
Selected LA is highlighted in data tables
Prettified gridlines to ensure there is always a major gridline above or below the max or min points on plots
There is still a significant amount of work needed to test the plotting functions (and some new other functions) as well as the server modules and some UI aspects. Also, bar charts are available for the Regional page (follow a similar style to the line charts, however it is unsure as to whether users would want these as well/ how much value added they bring).
A warning is appearing in some plots due to missing data in the middle of a data series which the {ggiraph} package does not like, this has been raised with the package author.
Pull request overview
This is the development of the Regional Level page of LAIT.
There has also been significant improvements made to the rest of the app.
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
The app does not include the Regional Level page of LAIT. There are also several issues that need addressing, such as incorrect rankings, missing formatting, styling of the app and a lot more.
What is the new behaviour?
The full functionality (bar the bar charts) of the Regional Level Page of LAIT has been replicated. This includes all those listed in the Regional Level Page issue.
There have also been a number of other improvements:
dfeshiny::external_link()global.R(wasright_join(), should have beenleft_join()){dfeshiny}cookies functionsAnything else
There is still a significant amount of work needed to test the plotting functions (and some new other functions) as well as the server modules and some UI aspects. Also, bar charts are available for the Regional page (follow a similar style to the line charts, however it is unsure as to whether users would want these as well/ how much value added they bring).
A warning is appearing in some plots due to missing data in the middle of a data series which the
{ggiraph}package does not like, this has been raised with the package author.