Jt shiny template - Githubissues

dfe-analytical-services / local-authority-interactive-tool

Local Authority Interactive Tool

https://department-for-education.shinyapps.io/local-authority-interactive-tool/

MIT License

1 stars 0 forks source link

Jt shiny template #2

Closed JT-39 closed 2 months ago

JT-39 commented 2 months ago

Pull request overview

Refactoring the DfE shiny-template codebase so that it uses my style of coding. This includes:

Explicitly naming packages when calling functions
Using here:here() when dealing with file paths
Using base R pipe |>
Removing unnecessary packages and library() (except for {shiny}, {ggplot2} and {ggriaph} as these use a lot of internal functions)
Cleaning the package management with renv::clean()

Pull request checklist

Please check if your PR fulfills the following:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Tests have been run locally and are passing (shinytest2::test_app())
[x] Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Currently none of the styles described in the overview are implmented.

What is the new behaviour?

All these styles have been applied across the project (all app .R, test- and pre-commit.R scripts).