This is largely to merge the work done on building the static version of the Statistical Neighbour page. However, there have also been some improvements made to the css and wider app logic.
Pull request checklist
Please check if your PR fulfills the following:
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Tests have been run locally and are passing (shinytest2::test_app())
[x] Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())
What is the current behaviour?
Currently, there is no work done to create the Statistical Neighbour page. Also, the app needs some visual improvements such as removing unnecessary horizontal scroll bars, adjusting padding for a more aesthetic feel as well as improving some of the wider app logic such as repeated code or potential efficiency gains.
What is the new behaviour?
The Statistical Neighbour Level view has been recreated with a static method, in the script stat_neigh_page_features_workshop.R. All features (that are unique to the page) are replicated for a specific LA, Topic and Indicator.
There has been a decision to diverge from the original LAIT functionality on the plots. The current plots are copies of the plots found on the LA Level page, however, it is thought plots following a similar style to the Regional Level page would be more useful (focus and multi-choice plots). These are designed to (a) compare selected LA against its statistical neighbour LAs and (b) show a default LA with the option to add any statistical neighbour LAs, selected LA region or England to the plot (max 3 others).
Other changes have been made that aim to improve the app.
css to hide horizontal scroll bars when uneccessary (there is nothing to scroll across).
css to adjust the padding of the main panel to give more space for the page content.
Updated app logic to remove repetitive code (creating Years_num lots of times when it could be done once in the global.R
Changed the tooltip year label to show the descriptive year (similar to X-axes and table column names).
Pull request overview
This is largely to merge the work done on building the static version of the Statistical Neighbour page. However, there have also been some improvements made to the css and wider app logic.
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
Currently, there is no work done to create the Statistical Neighbour page. Also, the app needs some visual improvements such as removing unnecessary horizontal scroll bars, adjusting padding for a more aesthetic feel as well as improving some of the wider app logic such as repeated code or potential efficiency gains.
What is the new behaviour?
The Statistical Neighbour Level view has been recreated with a static method, in the script
stat_neigh_page_features_workshop.R. All features (that are unique to the page) are replicated for a specific LA, Topic and Indicator.There has been a decision to diverge from the original LAIT functionality on the plots. The current plots are copies of the plots found on the LA Level page, however, it is thought plots following a similar style to the Regional Level page would be more useful (focus and multi-choice plots). These are designed to (a) compare selected LA against its statistical neighbour LAs and (b) show a default LA with the option to add any statistical neighbour LAs, selected LA region or England to the plot (max 3 others).
Other changes have been made that aim to improve the app.
global.RAnything else
This will not close the add feature: Statistical Neighbour tab as the development app script and modules are still required.