dfe-analytical-services / local-authority-interactive-tool

Local Authority Interactive Tool
https://department-for-education.shinyapps.io/local-authority-interactive-tool/
MIT License
1 stars 0 forks source link

Dev all la #27

Closed JT-39 closed 3 weeks ago

JT-39 commented 3 weeks ago

Pull request overview

This adds all code logic for the All LA level page.

Pull request checklist

Please check if your PR fulfills the following:

What is the current behaviour?

The All LA level page and code is not currently in the app.

What is the new behaviour?

This provides all logic for the All LA level page, from the simple static workshop script, to the development app to the shiny module code.

In this pull request, the download data functionality is also addressed. Applied to the All LA page and the LA level page (across tables and charts - .csv / .xlsx and .png / .html respectively). This is built using a module stored in the mod_app_helpers.R script.

There is also a major refactoring of the formatting of the {reactable} table columns. An issue was arising that due to applying the pretty_num() prior to rendering the table, numbers were actually string variables and so created weird sorting orders. Now the conversion to pretty_num() is done during rendering of the table and so sorting works as would be expected.

Anything else

The download functionality needs to be applied to the Region and Statistical Neighbour pages.