search

dfellis / h3-node

H3 binding to Node using N-API
MIT License
30 stars 5 forks source link

WIP: Create prebuild before publish #24

Closed dorshay6 closed 5 years ago

dorshay6 commented 5 years ago

update-h3 will be used for development.

When someone will consume the package the prebuilt folder will be used if fits.

dfellis commented 5 years ago

Why is the entirety of the H3 repo being pulled into this repo?

dorshay6 commented 5 years ago

Still trying to figure out the best way - this is the way they did it in node-s2 before.

dfellis commented 5 years ago

Still trying to figure out the best way - this is the way they did it in node-s2 before.

Please revert it back to pulling the H3 C code by git tag. This repository should be obvious to anyone reading its source which code is binding related versus the core of the library (and it will also increase the repo size dramatically).

dorshay6 commented 5 years ago

Then