search

dfellis / h3-node

H3 binding to Node using N-API
MIT License
30 stars 5 forks source link

Switch to release build #31

Closed isaacbrodsky closed 4 years ago

isaacbrodsky commented 4 years ago

This was brought to mind thanks to helium/erlang-h3#12. Main change is to switch to switch to using the release configuration; other changes that are included are to ignore package-lock.json just as yarn.lock, and to have CMake invoke the build tool (I think there's a way you can avoid hard coding "Visual Studio 14 Win64" which was applied to h3-java but it's not critical right now.)

dfellis commented 4 years ago

Looks good! A couple of benchmarks show a major improvement in performance, while most look to be unaffected.

Will wait for all of the tests to pass and then I'll merge it.